Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Prioritize replica shard movement during shard #9153

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[Backport 2.x] Prioritize replica shard movement during shard #9153

merged 1 commit into from
Aug 7, 2023

Conversation

Poojita-Raj
Copy link
Contributor

…relocation (#8875)

  • add shard movement strategy setting

Signed-off-by: Poojita Raj poojiraj@amazon.com

  • add tests

Signed-off-by: Poojita Raj poojiraj@amazon.com

  • add changelog

Signed-off-by: Poojita Raj poojiraj@amazon.com

  • Add NodeVersionAllocationDecider check

Signed-off-by: Poojita Raj poojiraj@amazon.com

  • refactoring

Signed-off-by: Poojita Raj poojiraj@amazon.com

  • add annotation + refactor

Signed-off-by: Poojita Raj poojiraj@amazon.com

Signed-off-by: Poojita Raj poojiraj@amazon.com
(cherry picked from commit c6e4bcd)

Description

Manual backport of #8875 to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Poojita-Raj
[Segment Replication] Prioritize replica shard movement during shard …
d6b5839 
…relocation (opensearch-project#8875)

* add shard movement strategy setting

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* add tests

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* add changelog

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* Add NodeVersionAllocationDecider check

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* refactoring

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* add annotation + refactor

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

---------

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
(cherry picked from commit c6e4bcd)
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/opensearch-oci-object-storage.git with ref: 2.x
Skipping compatibility check for https://github.com/opensearch-project/opensearch-oci-object-storage.git
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git]

BUILD SUCCESSFUL in 22m 21s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #9153 (d6b5839) into 2.x (e59b21a) will decrease coverage by 0.10%.
Report is 3 commits behind head on 2.x.
The diff coverage is 75.36%.

@@             Coverage Diff              @@
##                2.x    #9153      +/-   ##
============================================
- Coverage     70.81%   70.72%   -0.10%     
- Complexity    57425    57448      +23     
============================================
  Files          4754     4754              
  Lines        271688   271750      +62     
  Branches      40070    40080      +10     
============================================
- Hits         192408   192204     -204     
- Misses        62717    63067     +350     
+ Partials      16563    16479      -84
Files Changed Coverage Δ
.../opensearch/client/indices/CreateIndexRequest.java 76.66% <0.00%> (-1.12%) ⬇️
...opensearch/client/slm/SnapshotLifecyclePolicy.java 0.00% <ø> (ø)
...ch/client/slm/SnapshotLifecyclePolicyMetadata.java 0.00% <ø> (ø)
.../opensearch/client/slm/SnapshotLifecycleStats.java 0.00% <ø> (ø)
...rch/client/slm/SnapshotRetentionConfiguration.java 0.00% <ø> (ø)
...h/script/mustache/MultiSearchTemplateResponse.java 56.25% <ø> (ø)
...rg/opensearch/index/rankeval/RankEvalResponse.java 77.14% <ø> (-11.43%) ⬇️
...va/org/opensearch/index/rankeval/RankEvalSpec.java 97.36% <ø> (+9.64%) ⬆️
...a/org/opensearch/index/rankeval/RatedDocument.java 81.03% <0.00%> (ø)
...va/org/opensearch/index/rankeval/RatedRequest.java 91.79% <ø> (+6.71%) ⬆️
... and 142 more

... and 439 files with indirect coverage changes

@tlfeng tlfeng merged commit ce8c6b1 into opensearch-project:2.x Aug 7, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Poojita-Raj @dbwiddis @tlfeng